Skip to content

chore: sqlite launch#4307

Merged
NathanFlurry merged 2 commits intomainfrom
02-24-chore_sqlite_launch
Feb 26, 2026
Merged

chore: sqlite launch#4307
NathanFlurry merged 2 commits intomainfrom
02-24-chore_sqlite_launch

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member Author

NathanFlurry commented Feb 25, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@railway-app
Copy link

railway-app bot commented Feb 25, 2026

🚅 Deployed to the rivet-pr-4307 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 25, 2026 at 8:28 pm
frontend-inspector 😴 Sleeping (View Logs) Web Feb 25, 2026 at 3:12 pm
mcp-hub ✅ Success (View Logs) Web Feb 25, 2026 at 6:50 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 25, 2026 at 3:04 am
ladle ❌ Build Failed (View Logs) Web Feb 25, 2026 at 3:01 am

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4307 February 25, 2026 03:00 Destroyed
@claude
Copy link

claude bot commented Feb 25, 2026

PR Review: SQLite Launch Blog Post

This PR adds a changelog blog post announcing SQLite support for Rivet Actors. The post is well-structured with clear code examples covering Basic, Drizzle ORM, Queues, Transactions, and Realtime React patterns.

Issues

Blocking

Incomplete section — "Built-in Database Explorer" (line 358)
The section body is just TODO. This should either be filled in with content or removed before publishing. A placeholder in a live blog post will look like an unfinished draft.

Non-blocking

Duplicate import from same module (Drizzle tab)

// Current
import { db } from "rivetkit/db/drizzle";
import { integer, sqliteTable, text } from "rivetkit/db/drizzle";

// Should be
import { db, integer, sqliteTable, text } from "rivetkit/db/drizzle";

Non-null assertions in React example without consistent guards
The form onSubmit and onClick handlers use connection! (non-null assertion) but connStatus !== "connected" check only renders a <div>Connecting...</div> fallback — it doesn't prevent the form from rendering. When connStatus === "connected" but connection is still null momentarily, this could throw. Either use optional chaining (connection?.addTodo(input)) or ensure the connected status guarantees a non-null connection.

Transaction example allows overdrafts
The transfer action doesn't validate balance >= amount before deducting. For a demo illustrating atomic transfers, it's worth adding a balance check or at least a comment noting this is intentionally omitted for brevity. Real-world readers often copy demo code directly.

Strong marketing claim to verify
The post claims Rivet is "the only open-source SQLite multi-tenant platform". Turso/libSQL, LiteFS, and others also offer multi-tenant SQLite with open-source components. This claim should be verified for accuracy or softened (e.g., "the only open-source actor-based multi-tenant SQLite platform").

Positives

  • Frontmatter is correct and complete per CLAUDE.md conventions.
  • The progression of examples (Basic → Drizzle → Queues → Transactions → Realtime) is pedagogically solid.
  • The Realtime React section clearly connects the actor and frontend sides.
  • Referenced doc pages (/docs/actors/sqlite and /docs/actors/sqlite-drizzle) exist in the repo.

Summary: The blocking issue is the TODO placeholder in "Built-in Database Explorer". Everything else is minor polish.


Review generated by Claude Sonnet 4.6

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4307 February 25, 2026 06:49 Destroyed
@NicholasKissel NicholasKissel force-pushed the 02-24-chore_sqlite_launch branch from 06f2b6e to 3ca21d0 Compare February 26, 2026 08:13
@NathanFlurry NathanFlurry merged commit cc11eb7 into main Feb 26, 2026
12 of 21 checks passed
@NathanFlurry NathanFlurry deleted the 02-24-chore_sqlite_launch branch February 26, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants